Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the singleton logger #93

Merged
merged 8 commits into from
Dec 23, 2023
Merged

Disable the singleton logger #93

merged 8 commits into from
Dec 23, 2023

Conversation

jwallet
Copy link
Contributor

@jwallet jwallet commented Dec 19, 2023 •
edited

We use a feature flag the enable it, so it can be toggled (enabled/disabled), we want it to prevent tracking requests when disabled

  • Added a disableXHRInterception function to Logger, can be called with stopNetworkLogging()
  • Updated App to start and stop the logger when unmounting with the back button

jwallet
jwallet commented Dec 19, 2023
View reviewed changes
src/__tests__/index.spec.ts Outdated Show resolved Hide resolved
@alexbrazier alexbrazier merged commit 1191b61 into alexbrazier:master Dec 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbrazier alexbrazier alexbrazier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jwallet @alexbrazier