Merge pull request scrapy#165 from andrix/master

Just a simple refactoring on *MemoryQueue classes that improve the performance
alexcepoi · Aug 10, 2012 · 19bcb44 · 19bcb44
2 parents 483a70c + ed87210
commit 19bcb44
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/scrapy/utils/queue.py b/scrapy/utils/queue.py
@@ -10,13 +10,11 @@ class FifoMemoryQueue(object):
 
     def __init__(self):
         self.q = deque()
-
+        self.push = self.q.append
-    def push(self, obj):
-        self.q.appendleft(obj)
 
     def pop(self):
-        if self.q:
+        q = self.q
-            return self.q.pop()
+        return q.popleft() if q else None
 
     def close(self):
         pass
@@ -28,8 +26,9 @@ def __len__(self):
 class LifoMemoryQueue(FifoMemoryQueue):
     """Memory LIFO queue."""
 
-    def push(self, obj):
+    def pop(self):
-        self.q.append(obj)
+        q = self.q
+        return q.pop() if q else None
 
 
 class FifoDiskQueue(object):