Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload on dotenv hidden files #117

Closed
brauliobo opened this issue Jan 8, 2018 · 4 comments · Fixed by #129
Closed

Reload on dotenv hidden files #117

brauliobo opened this issue Jan 8, 2018 · 4 comments · Fixed by #129

Comments

@brauliobo
Copy link

The default ignore pattern doesn't allow to reload on .env files of https://github.com/bkeepers/dotenv

@alexch
Copy link
Owner

alexch commented Jan 24, 2018

Unfortunately, all files beginning with dot are ignored. This is a limitation of the file-change-monitoring library we're using -- I'm not sure if it's inside the Listen gem itself, or lower down inside fsevent or whatever. If you happen to research this, please let me know what you find. Learn more at https://github.com/guard/listen#listen-adapters

@brauliobo
Copy link
Author

I've used before the listen gem to watch the .env files

@alexch
Copy link
Owner

alexch commented Jan 26, 2018

Good point! Here is the line where we add all dotfiles to the ignore list:

https://github.com/alexch/rerun/blob/master/lib/rerun/watcher.rb#L86

I believe I did this in order to match the shell-glob behavior (where * matches everything except dotfiles). Why didn't I ever add a --no-ignore-dotfiles option? I have a dim memory that I couldn't get it to work consistently across different adapters, but that may have been fixed once I moved over to using the Listen backend.

It shouldn't be difficult to implement; the hard(ish) part will be to write tests demonstrating the desired behavior and testing it across different adapters/platforms.

There's also this dude to reckon with: https://github.com/guard/listen/blob/master/lib/listen/silencer.rb

@alexch alexch closed this as completed in 9a5ad39 Jan 26, 2018
@alexch
Copy link
Owner

alexch commented Jan 26, 2018

Okay, I think I did it. I'll reopen this issue until I get confimation from you. Can you please try the master branch? https://github.com/alexch/rerun#installation-via-gemfile--bundler has instructions for using prerelease versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants