Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Recipe functionality doesn't check if the recipe's ID is null or not before proceeding #7

Open
jtpreston opened this issue Feb 23, 2018 · 2 comments
Assignees

Comments

@jtpreston
Copy link
Collaborator

Does not affect functionality at all, it just means that the server does extra work only for it to not succeed, though does not have any adverse effect on the system. A simple check to see if the ID is null where it also checks if the ID is a valid value would suffice, so that a user gets back an appropriate exception indicating an invalid request.

@jtpreston jtpreston added the bug label Feb 23, 2018
@jtpreston jtpreston self-assigned this Feb 23, 2018
@jtpreston
Copy link
Collaborator Author

I will fix this when the next sprint starts. This change will take a minute or less, super simple.

@alexcoll
Copy link
Owner

this is server side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants