Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables this crate to modify the file creation time on Windows. #84

Open
czy-29 opened this issue Aug 28, 2022 · 0 comments
Open

Enables this crate to modify the file creation time on Windows. #84

czy-29 opened this issue Aug 28, 2022 · 0 comments

Comments

@czy-29
Copy link

czy-29 commented Aug 28, 2022

Hi, I wrote this crate: https://crates.io/crates/filetime_creation
It extends the functionality of "filetime" to modify the file creation time on Windows.
Initially my idea was to make changes directly on "filetime" and submit a pull request for the changes to be fed back upstream. But take into account the following factors:

  • This change requires modifying the signature of the existing function, I'm not sure how this will affect SemVer.
  • Does a feature that only works on Windows affect the cross-platform nature of this crate.
  • Is it appropriate for other platforms to simply ignore the "ctime" parameter? If inappropriate, do other platforms have suitable means of modifying the file creation time.
  • Is "ctime" an appropriate name.

So I decided to implement this feature first as a standalone crate to meet my (and potentially others') needs. But in the long run I think this feature should be merged into this crate to avoid community splits.
So what do you think? Should this feature be merged into this crate or should it remain separate? If you can think of a good way to implement this functionality into this crate, I don't mind deprecating my crate and archive the corresponding repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant