Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the GzBuilder panic cases #77

Closed
dtolnay opened this issue Apr 4, 2017 · 0 comments
Closed

Document the GzBuilder panic cases #77

dtolnay opened this issue Apr 4, 2017 · 0 comments
Labels
easy help wanted

Comments

@dtolnay
Copy link
Member

dtolnay commented Apr 4, 2017

GzBuilder::filename and GzBuilder::comment both panic if the bytes contain 0.

Document these panics in a "Panics" section of the doc comment of those methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brson @dtolnay