Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upEmit a RFC 1952 compatible XFL flag again #138
Conversation
This comment has been minimized.
This comment has been minimized.
|
I would love to have this added to a new 1.0.1 release. Especially, it would be really great to have this fix released before Cargo switches to flate2 1.0. |
alexcrichton
merged commit e5036e6
into
alexcrichton:master
Nov 30, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
est31 commentedNov 30, 2017
RFC 1952 specifies the following values
for the XFL flag:
Commit 7e0390b has
changed our behaviour from conforming to that
to setting the XFL flag to 9 when compression
is best, and 0 when it is the fastest one.
We revert that change in order to have consistent
output with pre 1.0.0 versions of flate2 and also
to be consistent with RFC 1952 and the ecosystem
around it, e.g. unix tooling that assumes the
RFC specified layout for the XFL flag.
Fixes #137.