Emit a RFC 1952 compatible XFL flag again #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 1952 specifies the following values for the XFL flag: * 2: maximum compression, slowest * 4: fastest algorithm config Commit 7e0390b has changed our behaviour from conforming to that to setting the XFL flag to 9 when compression is best, and 0 when it is the fastest one. We revert that change in order to have consistent output with pre 1.0.0 versions of flate2 and also to be consistent with RFC 1952 and the ecosystem around it, e.g. unix tooling that assumes the RFC specified layout for the XFL flag. Fixes rust-lang#137.
|
I would love to have this added to a new 1.0.1 release. Especially, it would be really great to have this fix released before Cargo switches to flate2 1.0. |
|
Thanks! |
|
@alexcrichton thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 1952 specifies the following values
for the XFL flag:
Commit 7e0390b has
changed our behaviour from conforming to that
to setting the XFL flag to 9 when compression
is best, and 0 when it is the fastest one.
We revert that change in order to have consistent
output with pre 1.0.0 versions of flate2 and also
to be consistent with RFC 1952 and the ecosystem
around it, e.g. unix tooling that assumes the
RFC specified layout for the XFL flag.
Fixes #137.