Add C++ library compilation support. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Add specific C++ libraries, if enabled. | ||
| if self.cpp { | ||
| println!("cargo:rustc-link-lib=static=stdc++"); |
There was a problem hiding this comment.
This seems a little surprising to me, I would expect this to be dynamically linked by default. Perhaps this could be its own configuration option?
There was a problem hiding this comment.
Actually it doesn't compile if I omit this line, so I suppose rustc doesn't link the C++ standard library by default. :p
There was a problem hiding this comment.
Yeah I'd definitely believe that, but I think it may be best done as a dynamic dependency (e.g. removing static=) instead of a static one. Statically linking libstdc++ is pretty rare I believe.
alexcrichton
added a commit
that referenced
this pull request
Mar 30, 2015
Add C++ library compilation support.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.