Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If PKG_CONFIG is already overriden then default PKG_CONFIG_ALLOW_CROSS to yes #41

Closed
infinity0 opened this issue May 1, 2017 · 3 comments

Comments

@infinity0
Copy link

infinity0 commented May 1, 2017

I've been trying to cross-compile cargo and although I've succeeded now, I ran into several cases where I had to set random environment variables for it to work. Here, PKG_CONFIG_ALLOW_CROSS seems a bit unnecessary, if PKG_CONFIG is already overriden then probably the user/builder knows what they're doing and there is no need to put artificial guards in that make the process Just Not Work.

@infinity0
Copy link
Author

For reference, on Debian the cross-compiling pkg-config programs are called $(host-triplet)-pkg-config and they are just a simple wrapper around pkg-config.

This issue is more about the whole Rust ecosystem rather than this particular package, I'd rather not have to set 20 similar random environment variables in the future across various different crates.

@alexcrichton
Copy link
Member

Seems reasonable to me!

@lightern
Copy link

Hi, maybe a stupid question, but how should I use PKG_CONFIG_ALLOW_CROSS variable? I've been trying to find the answer for this everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants