Inconsistent argument order

[Arkanayan]

Compare the argument order of the functions

pub fn append_path_with_name<P: AsRef<Path>, N: AsRef<Path>>(
        &mut self,
        path: P, // path in the filesystem
        name: N, // path in the archive
    )

and

pub fn append_dir_all<P, Q>(
    &mut self, path: P, // path in the archive
    src_path: Q // path in the filesystem
)

In the functions, the argument orders are reversed. It may cause confusion.

[alexcrichton]

Oh dear this does look like a bad footgun! If this crate releases a breaking change I'll be sure to try to fix this.

[Arkanayan]

I understand, changing this would be a big decision. I just wanted to bring it to your notice. Thanks.