tokio-process can't coexist with tokio

[Twey]

tokio-core is now deprecated, and the new tokio crate has a completely different model for execution. Notably, there is AFAICT no way to get a tokio_core::reactor::Handle or anything similar from tokio, which makes many of tokio-process's functions uncallable.

[alexcrichton]

Thanks for the report! Once futures 0.2 is published I plan on updating.

[ipetkov]

@alexcrichton on an unrelated note, is the plan to release 0.3 once futures 0.2 is out?

[alexcrichton]

@ipetkov oh isn't this lib currently at 0.1?, making the futures 0.2 compatible release 0.2?

[ipetkov]

Unfortunately we've got a published, but yanked, 0.2 version. Releasing a new 0.2.x version will have breaking changes relative to 0.2.0 and will probably cause more problems for anyone that happens to be on 0.2.0.

I figured jumping directly to 0.3 will just bypass any of these headaches and start over!

[alexcrichton]

Oh I was gonna publish 0.2.1, while technically breaking I can't imagine anyone's actually relying on 0.2.0

[ipetkov]

Fair enough, will trust your judgement here, thanks!

[tarcieri]

What's the story here now that futures 0.2 is out?

[ipetkov]

@tarcieri I've created a milestone for tracking changes for a 0.2.x release

cc @alexcrichton

[alexcrichton]

Thanks @ipetkov! I wonder, does Tokio support futures 0.2 yet?

[Twey]

Yes, with the unstable-futures feature.

[ipetkov]

FWIW, according to tokio-rs/tokio#312 the "recommendation from the futures team is to not update libraries fully to 0.2", given that futures 0.3 is on the horizon.

[tarcieri]

What's the path forward here?

I think some of the comments in the OP are incorrect:

Notably, there is AFAICT no way to get a tokio_core::reactor::Handle or anything similar from tokio, which makes many of tokio-process's functions uncallable.

The tokio (as opposed to tokio-core) crate does emphasize using the run function as a simple API, but still supports an API similar to what tokio-core provided originally, however you can obtain a Runtime which has a reactor method that returns a Handle.

The problem is the tokio and tokio-core reactors are incompatible. From what I can tell separate of the discussion about upgrading futures, this crate just needs to be updated to be compatible with the tokio crate instead of tokio-core.

[Twey]

Yes, I believe that's true. I must have just missed that on my first time through — I guess the port is easier than I anticipated then.

[tarcieri]

It looks like #29 (tokio-core => tokio) and #30 (futures 0.2 upgrade) cover both of these problems as separate issues. Perhaps it's worth closing this issue and moving discussion there?

[Twey]

Fine by me.