This repository has been archived by the owner on Sep 24, 2022. It is now read-only.
Clippy run and implement Default for State and Enconder #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -179,11 +179,10 @@ impl rustc_serialize::Encodable for Value { | |||
| where E: rustc_serialize::Encoder | |||
| { | |||
| match *self { | |||
| Value::String(ref s) => e.emit_str(s), | |||
| Value::String(ref s) | Value::Datetime(ref s) => e.emit_str(s), | |||
There was a problem hiding this comment.
Could this stay as a separate branch? It's a little clearer like that and may change one day as well
|
@alexcrichton Done! Also added the fix for #102 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bunch of lints indicated by clippy, most common one was useless
format!. Most notable change is to implementDefaultforStateand derive it forEncoder. Also closes #102.