This repository has been archived by the owner on Sep 24, 2022. It is now read-only.
lookup() and lookup_mut() lifetime enhancements. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 30, 2016 16:09
Rationale: - The path has nothing to do with the result. - The path has no need to live as long as the Value/self. - In some cases it can be hard to actually build a path that meets the same lifetime requirements as the Value or String slice result.
|
Thanks! You should actually be able to remove the lifetime annotations entirely as elision should cover this all now. |
|
Well, that would be fantastic! I thought elision only worked if all lifetimes were the same. I'll test this tonight. |
|
You're right (of course). |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
the same lifetime requirements as the Value or String slice result.
I submit to you that lifetime elision will not work with my use cases.
I really need the 'path' lifetime to be completely disassociated from the Value or String slice result.
I tried to provide an example in my original Issue. If my example was confusing or poorly worded please ask me to clean it up and I will happily do so.
Thank you.