-
Notifications
You must be signed in to change notification settings - Fork 191
Expose part of de::ErrorInner publicly #364
Conversation
Could you expand a bit on the rationale for this change? What are you looking for to get out of these new accessors? |
My use case is to customize the error message displayed to the user, adding specific context and rewording them. I am using TOML as input file for my code, and currently manually transforming from |
Sorry but I unfortunately do not have time to review PRs to this crate right now. I hope to get a chance to review this in the future but I'm likely to be busy for some time now. |
No problem, this is not urgent on my side =) |
@alexcrichton, do you foresee having some time to review this in the near future? Or is there another maintainer for this crate? No pressure, I would like to know before I look for other solutions 😃 |
@alexcrichton or @ehuss, I would appreciate if one of you could give this a new look =) Thanks! |
Is this PR still being considered? |
I no longer need this functionality, but I'm happy to rebase and update the PR if there is a path for it to be reviewed & merged. |
@Luthaf In the event this PR is not merged, may I ask, did you find an alternative solution? My use case is the same as yours:
|
toml-rs has moved to https://github.com/toml-rs/toml_edit. Feel free to rebase your PR against that repo and open a new issue there. |
I don't have a need for this anymore, but thanks a lot for picking up this project! |
See #360.
The second commit exposes
de::ErrorKind
publicly, if this is not desired I can remove it. It should be fine to expose since it is already marked asnon_exhaustive
, using#[doc(hidden)]
.