Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after "ui: toggle bottom panel" command panel can be empty #5373

Closed
veksha opened this issue Jan 23, 2024 · 6 comments
Closed

after "ui: toggle bottom panel" command panel can be empty #5373

veksha opened this issue Jan 23, 2024 · 6 comments

Comments

@veksha
Copy link
Contributor

veksha commented Jan 23, 2024

this is not a bug. rather a feature request.

if panel was hidden on startup and you trigger this command you will see empty space.
i think it's better to switch to Console in this case.

@Alexey-T
Copy link
Owner

but for console, we have 2 separate commands!

  • show bottom panel / console
  • show+focus bottom panel / console

@veksha
Copy link
Contributor Author

veksha commented Jan 23, 2024

yes, but i use "toggle", not "show".
one keyboard shortcut to open/hide panel (it can be any panel)
it's better then have several shortcuts for different panels.
and showing empty panel is not useful to users. if hard to do - ok :)

@Alexey-T
Copy link
Owner

Alexey-T commented Jan 23, 2024

use case: user clears his Out panel. he toggles bottom panel - console appears. user fills again his Out panel and wants that toggle activates Out panel - but he fails now.

@Alexey-T Alexey-T added the talk label Jan 23, 2024
@veksha
Copy link
Contributor Author

veksha commented Jan 23, 2024

"empty space" - is no controls at all, no memo, not output, not validate, etc.
this empty form is only appearing once, if Cud was started without bottom panel and then user toggles it by using command.

after user selects Output panel or any other, then this empty form will not return, because panel selection or "toggle" remembers last selected panel.

Alexey-T added a commit that referenced this issue Jan 23, 2024
@Alexey-T
Copy link
Owner

fixed. pls test.

@Alexey-T Alexey-T added enhancement and removed talk labels Jan 23, 2024
@veksha
Copy link
Contributor Author

veksha commented Jan 23, 2024

nice, thanks!

@veksha veksha closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants