Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexer (None) specific settings influence other lexers on first paint #5519

Closed
ThaiDat opened this issue May 11, 2024 · 7 comments
Closed

Lexer (None) specific settings influence other lexers on first paint #5519

ThaiDat opened this issue May 11, 2024 · 7 comments
Labels

Comments

@ThaiDat
Copy link
Contributor

ThaiDat commented May 11, 2024

Regression: #5320

2024-05-11.07-52-59.mp4
@Alexey-T
Copy link
Owner

Alexey-T commented May 11, 2024

Can you describe in text, pls? I don't get the idea in video.

Steps to do on clean app?
I made "wrap_mode":1 in "lexer -.json" and it is not applied to python files, if main user.json has "wrap_mode":0.

@Alexey-T
Copy link
Owner

But I see some effect. if in the FIRST EMPTY tab we reopen different files, file may get wrap=on (because of None lexer) and then it keeps this wrap=on after loading python file.
I have the fix for it.
tell me your About-window info, so I will give beta.

Alexey-T added a commit that referenced this issue May 11, 2024
@Alexey-T Alexey-T added the bug label May 11, 2024
Alexey-T added a commit that referenced this issue May 11, 2024
@ThaiDat
Copy link
Contributor Author

ThaiDat commented May 11, 2024

My about window:

CudaText
1.214.5.0
win-x86_64-win32, fpc 3.2.3

However, I am away from my desk. May test tomorrow

@Alexey-T
Copy link
Owner

Alexey-T commented May 11, 2024

Uploaded win64 beta to http://uvviewsoft.com/c/

EDIT
I dont think this is a regression, the same must be visible on old versions.

@Alexey-T Alexey-T changed the title Regression: Lexer (None) specific settings influence other lexers on first paint Lexer (None) specific settings influence other lexers on first paint May 12, 2024
@ThaiDat
Copy link
Contributor Author

ThaiDat commented May 13, 2024

Tested. It is good now.

@ThaiDat
Copy link
Contributor Author

ThaiDat commented May 24, 2024

An additional note that the fix made in this ticket also add the behavior desired in #5321

2024-05-24.12-14-04.mp4

@Alexey-T
Copy link
Owner

Good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants