Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll: Can we change the rule for Interfaces/Contracts to be suffixed with "Interface"? #74

Closed
thomasmoors opened this issue Jul 1, 2020 · 7 comments

Comments

@thomasmoors
Copy link

thomasmoors commented Jul 1, 2020

  1. This way it's compatible with PSR naming conventions.
  2. You can differentiate Interfaces from Traits by class name, otherwise they might be the same.

This poll was created based on a suggestion by the author: #44 (comment)
Please upvote with a thumbs up and downvote with a thumbs down.

image

@alexeymezenin
Copy link
Owner

alexeymezenin commented Jul 1, 2020

Most of the Laravel interfaces do not use the Interface suffix, as many Laravel packages and apps. I think that we should still follow PSR, but I'd like to hear what do you guys think before making changes.

Please vote.

@Tpojka
Copy link

Tpojka commented Jul 1, 2020

Keep in mind that this change will lot of currently not allowed namespaces which also doesn't affect this poll here per se. I just wanted to reveal it as some new option expected in future. Nevertheless I am for PSR standard.

@thomasmoors
Copy link
Author

thomasmoors commented Jul 2, 2020

@alexeymezenin What would be a sane end date?

@alexeymezenin
Copy link
Owner

@thomasmoors I guess a couple of weeks is enough

@thomasmoors
Copy link
Author

@thomasmoors I guess a couple of weeks is enough

I think those 4 votes (including 1 of mine) will be it 😄

@alexeymezenin
Copy link
Owner

@thomasmoors I'll make the changes during the next few days.

@alexeymezenin
Copy link
Owner

Done. I've updated all the translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants