Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add three algorithms #30

Merged
merged 7 commits into from Jan 30, 2022
Merged

feat: Add three algorithms #30

merged 7 commits into from Jan 30, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2022

These were really easy to add, they're functionally identical to the ones in the older repository, the only thing I changed was proper tests for reverse (it only had palindromes) and morse, which never attempted decoding.

What does this PR do?

Added the following ciphers and string manipulation algorithms:

  • Reverse
  • Morse
  • VIgenere

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

@ghost ghost changed the title Add files via upload Added three algorithms Jan 29, 2022
@alexfertel
Copy link
Owner

alexfertel commented Jan 30, 2022

Thanks for doing this! ❤️

The formatter failed cause of the import order, so that should be easy to fix (not sure why it didn't fail locally). There is some minor stuff as well, should be quick! Also, remember to update the README with the added algos, that way we keep track of stuff.

Otherwise looks good to me. I learned a couple of things too, so thank you again!

src/ciphers/morse_code.rs Show resolved Hide resolved
src/ciphers/morse_code.rs Show resolved Hide resolved
src/ciphers/vigenere.rs Outdated Show resolved Hide resolved
src/ciphers/vigenere.rs Outdated Show resolved Hide resolved
Maria and others added 3 commits January 30, 2022 14:11
Co-authored-by: Alexander González <alexfertel97@gmail.com>
Co-authored-by: Alexander González <alexfertel97@gmail.com>
@ghost
Copy link
Author

ghost commented Jan 30, 2022

I just changed it by adding #[cfg(test)] above the decode function

@ghost
Copy link
Author

ghost commented Jan 30, 2022

Odd, GH tells me theres a review requesting change but I can't find one, all four are resolved.

@alexfertel
Copy link
Owner

Hmmm, not sure, it looks good to me!

@ghost
Copy link
Author

ghost commented Jan 30, 2022

Hmmm, not sure, it looks good to me!

Probably GH just being weird, hope the checks pass :)

@ghost
Copy link
Author

ghost commented Jan 30, 2022

oof, I'll have a look at that soon

@alexfertel
Copy link
Owner

Woohoo! GJ!

@ghost
Copy link
Author

ghost commented Jan 30, 2022

There we go, nice.

@alexfertel alexfertel changed the title Added three algorithms feat: Add three algorithms Jan 30, 2022
@alexfertel alexfertel merged commit f64fb76 into alexfertel:main Jan 30, 2022
@alexfertel alexfertel assigned ghost Jan 30, 2022
@alexfertel alexfertel added the enhancement New feature or request label Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant