New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add three algorithms #30
Conversation
Thanks for doing this! ❤️ The formatter failed cause of the import order, so that should be easy to fix (not sure why it didn't fail locally). There is some minor stuff as well, should be quick! Also, remember to update the README with the added algos, that way we keep track of stuff. Otherwise looks good to me. I learned a couple of things too, so thank you again! |
Co-authored-by: Alexander González <alexfertel97@gmail.com>
Co-authored-by: Alexander González <alexfertel97@gmail.com>
I just changed it by adding |
Odd, GH tells me theres a review requesting change but I can't find one, all four are resolved. |
Hmmm, not sure, it looks good to me! |
Probably GH just being weird, hope the checks pass :) |
oof, I'll have a look at that soon |
Woohoo! GJ! |
There we go, nice. |
These were really easy to add, they're functionally identical to the ones in the older repository, the only thing I changed was proper tests for reverse (it only had palindromes) and morse, which never attempted decoding.
What does this PR do?
Added the following ciphers and string manipulation algorithms:
All Submissions:
New Feature Submissions: