feat: add sorting_tests macro to almost all sorting algorithms
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, that was my first thought. In the end they are all sorting algos, so it probably makes sense to just create some sort of abstraction over the algorithms and call a I'm happy to review those changes in separate PRs! |
alexfertel
previously approved these changes
Dec 15, 2022
|
Ah, there is a small formatting issue! @aliencdh would you mind fixing those so that I can merge this PR? |
|
@alexfertel ofc, i’ll format them now |
alexfertel
changed the title
sorting_tests macro to most sorting algorithmssorting_tests macro to almost all sorting algorithms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few algorithms I wasn't able to do this for, because the function signatures didn't match those expected by the macro. Perhaps it'd be a good idea to standardize those too?