Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor nits. Default state in mdio state case #51

Open
secworks opened this issue Nov 6, 2020 · 0 comments
Open

Minor nits. Default state in mdio state case #51

secworks opened this issue Nov 6, 2020 · 0 comments

Comments

@secworks
Copy link

secworks commented Nov 6, 2020

Running the VCU118 10G example design with Vivado and linter. One nits highlighted is the case statement implementing the mdio command FSM engine starting at 1043 in fpga.v. That case statement end with:

            4'd12: begin
                // done
                state_reg <= 4'd12;
            end
        endcase

Which of course ensure that it stops when done. But since the state space is incomplete the toots gets annoyed. How abot simply adding a

default:
state_reg <= 4d0;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant