Skip to content
This repository has been archived by the owner on Mar 2, 2019. It is now read-only.

Add "TEMP/TEMPORARY" to CREATE TABLE statement #12

Closed
shadeven opened this issue Apr 26, 2015 · 4 comments
Closed

Add "TEMP/TEMPORARY" to CREATE TABLE statement #12

shadeven opened this issue Apr 26, 2015 · 4 comments

Comments

@shadeven
Copy link
Contributor

Adds "TEMP/TEMPORARY" as an optional clause to CREATE TABLE statement.

String sql = SQLiteQueryBuilder
  .createTable("myTable")
  .temp()
  .column(column)
  .toString();
@shadeven
Copy link
Contributor Author

@alexfu, please review the spec above and assign to me. I will start upon your response.

@alexfu
Copy link
Owner

alexfu commented Apr 27, 2015

@shadeven I'm thinking we should refactor such that a client would write it like so...

String sql = SQLiteQueryBuilder
  .create()
  .temp()
  .table("myTable")
  .column(column)
  .toString();

This will also allow us to support CREATE INDEX statements...

String sql = SQLiteQueryBuilder
  .create()
  .index("index-name")
  .on("mytable")
  .column("col1", "col2")
  .toString();

I can work on the refactoring and will let you know when it's done.

@shadeven
Copy link
Contributor Author

@alexfu, I am ok with that. Since the project was inspired by jOOQ, the new syntax makes it more like jOOQ, which is a good thing. Let me know when the refactoring is done.

@alexfu
Copy link
Owner

alexfu commented Jul 5, 2015

@shadeven I think you can proceed with this now that the refactoring has been finished.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants