Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No checks for the presence of console #26

Closed
terinjokes opened this issue Sep 19, 2013 · 5 comments · Fixed by #29
Closed

No checks for the presence of console #26

terinjokes opened this issue Sep 19, 2013 · 5 comments · Fixed by #29

Comments

@terinjokes
Copy link

The event module doesn't check for the presence of console, or the 'error' or 'trace' methods before using

The utils module doesn't check for the presence of console.

@Raynos
Copy link
Contributor

Raynos commented Sep 20, 2013

We need to add var console = require("console") to the top of those files

@terinjokes
Copy link
Author

The console module doesn't shim console.trace so we'll still have to do a check if the method exists, so I don't see any benefit to including the module.

@Raynos
Copy link
Contributor

Raynos commented Sep 20, 2013

we can add console.trace to the shim

@AndreasMadsen
Copy link
Collaborator

@terinjokes how does the console module not support trace? see: https://github.com/Raynos/console-browserify/blob/master/index.js#L24

@terinjokes
Copy link
Author

@AndreasMadsen ah, sorry. when @Raynos said to require('console') i assumed he meant the console module, not console-browserify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants