Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traced problem with browserify back to browser-builtins. #35

Closed
icetan opened this issue Oct 25, 2013 · 1 comment
Closed

Traced problem with browserify back to browser-builtins. #35

icetan opened this issue Oct 25, 2013 · 1 comment

Comments

@icetan
Copy link

icetan commented Oct 25, 2013

I got some weird problems with tape after upgrading browserify from 2.29.1 to 2.30.0 and I traced the problem down to the browser-builtins package.

When I switched from browser-builtins version ~2.0.1 back to ~1.0.1 in browserify 2.30.0 and 2.34.3 I don't get the errors.

I dissected the browser-builtins repo and found that the last working commit for me is c1bc56a, then there is one commit that won't work at all e08cda5 and the commit after that 5fa8c3f produces my error (I had to manually copy the _shims.js file from a later commit because it was required).

Running my browserifyed tape tests in Chrome with browser-builtins from commit 5fa8c3f and later results in each tape test running many times instead of just once.

In the console this error is shown a couple of times:

(node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit.
    EventEmitter.addListener

So I'm guessing that I have some problem with the EventEmitter implementation.

Unfortunately the diff on commit e08cda5 and 5fa8c3f is quite large and I haven't had time to look in to the details of the changes yet.

@icetan
Copy link
Author

icetan commented Oct 25, 2013

Uuuuhhhh.... I'm really sorry. I was running a really old version of tape it turns out.

Everything works, so ignore my stupid issue!

Keep up the great work and sorry to bother you!

@icetan icetan closed this as completed Oct 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant