You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I got some weird problems with tape after upgrading browserify from 2.29.1 to 2.30.0 and I traced the problem down to the browser-builtins package.
When I switched from browser-builtins version ~2.0.1 back to ~1.0.1 in browserify2.30.0 and 2.34.3 I don't get the errors.
I dissected the browser-builtins repo and found that the last working commit for me is c1bc56a, then there is one commit that won't work at all e08cda5 and the commit after that 5fa8c3f produces my error (I had to manually copy the _shims.js file from a later commit because it was required).
Running my browserifyed tape tests in Chrome with browser-builtins from commit 5fa8c3f and later results in each tape test running many times instead of just once.
In the console this error is shown a couple of times:
(node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit.
EventEmitter.addListener
So I'm guessing that I have some problem with the EventEmitter implementation.
Unfortunately the diff on commit e08cda5 and 5fa8c3f is quite large and I haven't had time to look in to the details of the changes yet.
The text was updated successfully, but these errors were encountered:
I got some weird problems with
tape
after upgradingbrowserify
from2.29.1
to2.30.0
and I traced the problem down to thebrowser-builtins
package.When I switched from
browser-builtins
version~2.0.1
back to~1.0.1
inbrowserify
2.30.0
and2.34.3
I don't get the errors.I dissected the
browser-builtins
repo and found that the last working commit for me is c1bc56a, then there is one commit that won't work at all e08cda5 and the commit after that 5fa8c3f produces my error (I had to manually copy the_shims.js
file from a later commit because it was required).Running my
browserify
edtape
tests in Chrome withbrowser-builtins
from commit 5fa8c3f and later results in eachtape
test running many times instead of just once.In the console this error is shown a couple of times:
So I'm guessing that I have some problem with the
EventEmitter
implementation.Unfortunately the diff on commit e08cda5 and 5fa8c3f is quite large and I haven't had time to look in to the details of the changes yet.
The text was updated successfully, but these errors were encountered: