Added working modbus support for RTU modbus #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added modbus support
|
Thanks for contributing this work! Could you please update the tests to match please? |
added 2 commits
January 15, 2013 18:37
|
Everything should be there now dude |
|
Hey man, just wondered whether you were going to add these features? |
added modbus hex
alexgorbatchev
added a commit
that referenced
this pull request
Jan 25, 2013
Added working modbus support for RTU modbus
|
Thanks for contributing! |
|
Wait... what happened to crc16CCITT support? |
|
I assumed this was a fix but after the second look it might not be the case. @thebadger412, could you please elaborate on your changes? |
|
Sorry I gave you the wrong file, Nothing was meant to be removed. I was just adding my own function for modbus rtu support for strings and hex.. I will sort it out in next few days |
|
Cool. Thanks, guys. |
|
Hey @thebadger412, i'd like to follow up on this. Let us know :) |
alexgorbatchev
added a commit
that referenced
this pull request
May 5, 2015
Added working modbus support for RTU modbus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the ARC code didn't work for Modbus RTU, It now does with these added methods