Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listSubTreeBFS only lists direct children, not subchildren. #127

Open
alexmakarevich opened this issue Jan 27, 2023 · 0 comments
Open

listSubTreeBFS only lists direct children, not subchildren. #127

alexmakarevich opened this issue Jan 27, 2023 · 0 comments

Comments

@alexmakarevich
Copy link

Hello.

I've spotted a bug in the listSubTreeBFS method.

It's supposed to return a list of all children and their subchildren of a node, but since the bump of async, this is no longer the case.

Prior usage of async.reduce "faked recursion" by mutating the accumulator (referred to as "memo" by async).
Newer versions of async disregard this mutation, breaking the functionality of listSubTreeBFS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant