Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NA alignment is off #105

Closed
alexhallam opened this issue Oct 19, 2021 · 2 comments
Closed

NA alignment is off #105

alexhallam opened this issue Oct 19, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request hacktoberfest-accepted hacktoberfest-accepted help wanted Extra attention is needed

Comments

@alexhallam
Copy link
Owner

NA alignment should be as follows for the different data types:

type format
double right aligned, but not pass the decimal
int right aligned
char (and every other type) left aligned

This is an example of the correct formatting of NAs.

   name                  height   mass hair_color   
   <chr>                  <int>  <dbl> <chr>        
 1 Luke Skywalker           172   77   blond        
 2 C-3PO                    167   75   NA           
 3 R2-D2                     96   32   NA           
 4 Darth Vader              202  136   none         
 5 Leia Organa              150   49   brown        
 6 Owen Lars                178  120   brown, grey  
 7 Beru Whitesun lars       165   75   brown        
 8 R5-D4                     97   32   NA           
 9 Biggs Darklighter        183   84   black        
10 Obi-Wan Kenobi           182   77   auburn, white
11 Anakin Skywalker         188   84   blond        
12 Wilhuff Tarkin           180   NA   auburn, grey 
13 Chewbacca                228  112   brown        
14 Han Solo                 180   80   brown        
15 Greedo                   173   74   NA           
16 Jabba Desilijic Tiure    175 1358   NA           
17 Wedge Antilles           170   77   brown        
18 Jek Tono Porkins         180  110   brown        
19 Yoda                      66   17   white        
20 Palpatine                170   75   grey         
21 Boba Fett                183   78.2 black        
22 IG-88                    200  140   none         
23 Bossk                    190  113   none         
24 Lando Calrissian         177   79   black        
25 Lobot                    175   79   none         
26 Ackbar                   180   83   none         
27 Mon Mothma               150   NA   auburn       
28 Arvel Crynyd              NA   NA   brown 

This is the current NA formatting.

image

Note that NA should end where a where a float would end (right before the decimal).

@alexhallam alexhallam added enhancement New feature or request help wanted Extra attention is needed hacktoberfest-accepted hacktoberfest-accepted labels Oct 19, 2021
@alexhallam alexhallam self-assigned this Oct 21, 2021
@alexhallam
Copy link
Owner Author

#106

@alexhallam
Copy link
Owner Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest-accepted hacktoberfest-accepted help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants
@alexhallam and others