Inserting newline places closing brace at wrong indentation level

[andreyorst]

only [] and various quotes are expanding normally with newline.

[alexherbo2]

Auto-pairs doesn’t handle the indentation by itself, but triggers the normal hooks.

When inserting a new-line, it goes up and inserts a new-line.

[andreyorst]

hm, indeed, I didn't noticed that before, because mainly inserted closing pair at right indentation already. Sorry for wrong issue report, but where should I dig then?

[alexherbo2]

Hm, maybe on Kakoune directly.

[alexherbo2]

Which language is concerned?

[andreyorst]

Which language is concerned?

c-family

[andreyorst]

So I've noticed that indentation actually works correctly, however the empty line is placed at wrong positon, and closing bracket too.
When auto-pairs are disabled, after I enter { and hit Enter the next line appears indented as it should:

(That thin gray line is a tab character)
With auto-pairs turned on, the indented line also exists, however the empty line is added before it, and closing paren is added on the indented line. That's the problem, and it's not issue with kakoune actually:

[maximbaz]

Does it repro with minimal kakrc and latest commit from this master? Doesn't seem to repro for me, also (finally working) unit tests are green and there are a couple of tests for a similar example.

[andreyorst]

yes. Fully empty kakrc, and manual sourcing auto-pairs still produces this issue for c filetype

[maximbaz]

What OS do you use?

Can you clone this repo and run unit tests, and tell me if any of them fail?

$ cd /path/to/auto-pairs
$ test/run /path/to/cloned/kakoune-repo/

[andreyorst]

I've re-cloned the repo, and issue is still here.
My os is Arch Linux, login shell is bash, user shell is zsh. sh is linked to dash.

tests log:

auto-pairs
    delete-closer
    delete-new-line
    delete-opener
    delete-opener-closer
    delete-single-quote
    delete-space
    insert-closer
    insert-nested-pairing
    insert-new-line
    insert-new-line-below
    insert-opener
    insert-opener-closer
    insert-single-quote
    insert-space
    surround-delete-opener
    surround-delete-space
    surround-insert-opener
    surround-insert-space

Resume: 18 tests, 0 failures

[maximbaz]

Weird! My setup is very similar to yours and I don't repro.

If you want to help investigate, consider adding a test for your exact example and confirming that this unit test fails, because it's reeeeeally suspicious.

[andreyorst]

strangely enough the test I've wrote passes just fine.

[andreyorst]

Here's me launching freshly compiled Kakoune from master branch, with -n and sourcing everything manually:

[maximbaz]

I wish I could help but I really have no clue how to investigate this if it doesn't repro via unit tests and on my machine with the same OS and shell as you 😞

[andreyorst]

this also happens for me in termux. I'll try to do fresh install of something like ubuntu in VB and try there to see if it is reproduces.

[andreyorst]

So. I did just downloaded Ubuntu 18.10 iso from official Ubuntu page.
Installed it in virtualbox.
Cloned kakoune and auto-pairs
Installed build-essential, libncurses-dev, and pkg-config or something like that.
Compiled kakoune, and done this:

All test are passing just fine.

[bugworm]

Kak in termux, rust lang

[maximbaz]

Managed to reproduce! So it happens only if you run auto-pairs-enable manually, and doesn't happen when it runs from WinCreate hook!

hook global WinCreate .* %{ auto-pairs-enable }

If I have this, it works fine. If I comment this and run auto-pairs-enable myself like on gifs above, the issue appears.

I have no clue as to why. @alexherbo2? But presumably plug.kak runs the command not from WinCreate hook and that's why you experience the issue?

[alexherbo2]

Maybe a race condition with the execution of hooks between the languages and auto-pairing.

[andreyorst]

@maximbaz personally I don't run this command in plug command, but you're right, plug.kak doesn't use hooks for commands it executes them with execute-command one by one, so this will still be reproducible with plug.kak.

Using your hook it works fine. But I tend to disable this automatic pair insertion time to time, as sometimes it just not what I want. In rare cases, but still.

[andreyorst]

Also using auto-pairs-toggle after successful hook breaks everything again.

[andreyorst]

Maybe a race condition with the execution of hooks between the languages and auto-pairing.

Yeah, so if I turn auto pairs on and then set filetype option to c it works fine. If I set filetype option to c and toggle auto pairs after it doesn't.

[maximbaz]

Not sure if this can be solved in a meaningful way in the plugin itself. Was thinking about something like this to ensure auto-pairs' hooks are first:

• save current filetype
• set filetype to '' to
• execute auto-pairs-enable
• restore filetype

But it feels hacky, also with c filetype it's just a lucky coincidence that c hooks don't misbehave after auto-pairs does its magic.

[alexherbo2]

It’s a problem that should be addressed upstream.

[dpc]

I cam here to report this exact issue. Can anyone describe in more detail what is the problem?

[andreyorst]

Can anyone describe in more detail what is the problem?

Seems like if plugin defines it's hooks before filetype hooks the order for executing hooks is correct. Solution for now is to activate plugin by such hook: hook global WinCreate .* %{ auto-pairs-enable }

It’s a problem that should be addressed upstream.

Well I guess then you should adress it upstream as a maintainer? I'm not sure how to do it properly since I don't know deep enough how your plugin is working, and what's actually causing an issue here.

[alexherbo2]

Even without auto-pairs, the indentation is wrong.

The indentation is false when inserting a new line between braces.

The indentation is not corrected when inserting the closing brace at the beginning of the line.

[andreyorst]

I know that there are problems with lisp filetype indentation (it adds extra space on every line for some reason), but for c-family I was pretty much pleased with indentation handling most of the time.

[alexherbo2]

I can add a fix, but there is two bugs that should be corrected in C-family before.

[dgrisham]

I assume this is still waiting on mawww/kakoune#2590?

[andreyorst]

I don't think that this issue is related

[alexherbo2]

mawww/kakoune#2806

[alexherbo2]

@andreyorst 6abc67f Does it help?

[andreyorst]

it looses indentation. Cursor is placed correctly though.

With this hook hook global WinCreate .* %{ auto-pairs-enable }:

int main() {|}
RET
int main() {
    |
}

after 2 auto-pairs-toggle:

int main() {|}
RET
int main() {
|
}

[alexherbo2]

I don’t know how to solve the hook execution order.

[andreyorst]

Actually, because of this long standing issue I've stopped using auto pairs in all editors :D

But your solution for surrounding is outstanding and I use this plugin for it every day.

[alexherbo2]

Wow thanks