Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customising the actionBarButtonItem and closeBarButtonItem via subclassing the PhotosViewController #6

Closed
deepmode opened this issue Aug 16, 2017 · 3 comments
Labels

Comments

@deepmode
Copy link

I was trying to override the actionBarButtonItem and closeBarButtonItem (just for the look and feel) via subclassing the PhotosViewController. The Swift compiler have this warning "Overriding non-open var outside of its defining module". To get this working, I have to change the method declaration from public to open. I wonder if this the only option for just changing the look and feel.

@alexhillc
Copy link
Owner

Hi @deepmode, thanks for the report. All exposed overrideable variables should have the ‘open’ qualifier. If they don’t, it’s a mistake on my part. I can fix this later today and push out a new release.

@alexhillc
Copy link
Owner

Fixed in: 51073b3

@deepmode
Copy link
Author

Thanks!

@alexhillc alexhillc added the bug label Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants