Add build dependency of pytest

[archisman-panigrahi]

It was failing to build on Launchpad, and showed ModuleNotFoundError: No module named 'pytest'. After adding this build dependency the PPA package works again.

[alexhuntley]

That's weird, is Launchpad trying to run the tests?

[archisman-panigrahi]

Launchpad (and any proper Debian packaging system) runs some kind of tests before packaging python apps. I have noticed (in other software) that it even points out syntax error when a slightly old code may not work with a new release of python.

Here is one of those build logs (the error ModuleNotFoundError: No module named 'pytest' is at the very end).

More interestingly, the pytest did not go into the dependency of the final debian package.

[alexhuntley]

Launchpad (and any proper Debian packaging system) runs some kind of tests before packaging python apps. I have noticed (in other software) that it even points out syntax error when a slightly old code may not work with a new release of python.

Interesting, I wasn't aware of this.

More interestingly, the pytest did not go into the dependency of the final debian package.

It might be because pytest isn't listed as a requirement in setup.py?

P.S. Are you uploading these builds manually? Or is Launchpad able to make them automatically from this repo?

[archisman-panigrahi]

It might be because pytest isn't listed as a requirement in setup.py?

It may be so, but I don't know if `pytest` is really required for the program to run. In my computer pytest is not installed, and still the program runs fine.

…

On Mon, Jan 25, 2021 at 8:37 PM Alex Huntley ***@***.***> wrote: Launchpad (and any proper Debian packaging system) runs some kind of tests before packaging python apps. I have noticed (in other software) that it even points out syntax error when a slightly old code may not work with a new release of python. Interesting, I wasn't aware of this. More interestingly, the pytest did not go into the dependency of the final debian package. It might be because pytest isn't listed as a requirement in setup.py? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXL2XENE73MQ3YLXGNH5ELS3WCMJANCNFSM4WRN7QRA> .

[alexhuntley]

Yes pytest is only needed to run the tests, the app itself doesn't require it.