Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koa support #1

Open
niftylettuce opened this issue Jul 14, 2017 · 7 comments
Open

Koa support #1

niftylettuce opened this issue Jul 14, 2017 · 7 comments

Comments

@niftylettuce
Copy link

It'd be great if we can get Koa support in here per agenda/agendash#30 and agenda/agendash#45 (comment) cc @joeframbach

@alexindigo
Copy link
Owner

Agree, it would be awesome. Although I don't have much experience with Koa. Do you know what is lacking to make them work together? Thanks.

@joeframbach
Copy link

Hi Alex :) I am also not familiar with Koa. I'm just responding to Github issue requests and passing it forward.

@alexindigo
Copy link
Owner

Hi Joe. How are things? :)

I just noticed that issue is from 2016 :)
But in the same time, it's not exactly clear what is the original problem.

@OmgImAlexis
Copy link

I'd like to add koa support to this but it looks like the repo isn't really maintained anymore. If this is the case would you be okay with the agenda org taking this project over?

Ref: https://github.com/agenda

@alexindigo
Copy link
Owner

Hey, thanks for your interest. I'm still using the library in few of my projects.
How do you feel if we start with a PR and see how it goes from there.

@OmgImAlexis
Copy link

Is there any documentation on how to add a new adapter and/or a recommended way to do it?

@alexindigo
Copy link
Owner

This folder will expose you to the world of pain :)
https://github.com/alexindigo/agnostic/tree/master/notes

Probably most straightforward way to approach it, would be to print out koa's Request / Response object (properties and methods) and see how it aligns with the existing API.

Most likely you'd need to change existing API and make it all async functions, so it would support both models. Then there is a question of that other servers – how they work with async functions/promises instead of callbacks. Seems like it'd be breaking change and most likely would require to drop support for old versions, in order to fully embrace the brave new world of async functions.

Good luck, thank you. And let me know if you hit a roadblock or there are questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants