Layout broken on iPad, app running in Split view

[Piidro]

Problem Description:
Hello, seems that this library doesn't work when bulletin is opened when app is not taking 100% of the screen. When running in any split view combinations (1/4, 2/4, 3/4 or 1/3, 2/3 of the screen widths) the bulletin view is displayed as it would take the whole screen estate, therefore part of it is hidden. I have tried both showBulletin(above:animated:completion:) or showBulletin(in:animated:completion) they seem to give same result. I attach an image of the problem to further clarify the issue.

Is there any workaround?

Steps to reproduce:
Run the app, present bulletin board when app size has been reduced with split view. Present bulletin board with either showBulletin(above:animated:completion:) or showBulletin(in:animated:completion)

Environment:

• Device: iPad 11" Pro, iPad 12.9" Pro
• OS: iOS 13.0, 13.1, 13.2
• Version of BulletinBoard: 4.1.0

[arguiot]

I also have this problem @alexaubry could you have a look, please?

[Piidro]

I think I managed to fix this issue. To my understanding, this is caused by animation transition in BulletinPresentationAnimationController having incorrect frame for toVC. I opened up a PR #173 with the fix. I don't know if it is the correct way to go though but you who are interested on the subject can take a look!

[arguiot]

Great, I’ll take a look and try to install it in my app to see if the issue is fixed.

[alexisakers]

The fix was released in 4.1.1, thanks for your patience.