Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIKitCore con < iOS 11 #180

Closed
diegogarciar opened this issue Jun 15, 2020 · 2 comments
Closed

UIKitCore con < iOS 11 #180

diegogarciar opened this issue Jun 15, 2020 · 2 comments

Comments

@diegogarciar
Copy link

Problem Description:
Hello, a user has iOS 11 and app is crashing on

BulletinCloseButton ->configureSubviews
accessibilityLabel = Bundle.UIKitCore.localizedString(forKey: "Close", value: "Close", table: nil)

with an error of

Fatal error: Unexpectedly found nil while unwrapping an Optional value.

It seems you're force unwrapping Bundle(identifier: "com.apple.UIKitCore")! at Bundle.UIKitCore but it's not available on older OS? Anyway, a simple optional might be enough.

Steps to reproduce:
present any bulletin using an older iOS version

Environment:

  • Device: iPhone 5 and 8
  • OS: iOS 10.3.4 and iOS 11.4.1
  • Version of BulletinBoard: 4.1.1
@diegogarciar
Copy link
Author

I see there's already a pull request for this fix, We can close this issue when it goes to master

@alexisakers
Copy link
Owner

The fixed shipped in 5.0, thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants