Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 11 devices treated as rounded corners #45

Closed
4 tasks done
CaliCastle opened this issue Dec 22, 2017 · 1 comment
Closed
4 tasks done

iOS 11 devices treated as rounded corners #45

CaliCastle opened this issue Dec 22, 2017 · 1 comment
Projects

Comments

@CaliCastle
Copy link
Contributor

CaliCastle commented Dec 22, 2017

New Issue Checklist

Issue Description

iPhone 7 iOS 11.2:
messages image 1992398790
iPhone 8 Plus iOS 11.2:
messages image 573817002

I do not think the condition failed even when it's not iPhone X that doesn't have rounded corners. Because in iOS 11 they are all under safe area so screenHasRoundedCorners will always be true in iOS 11+

@available(iOS 11.0, *)
    fileprivate var screenHasRoundedCorners: Bool {
        let insets = view.safeAreaInsets
        return (insets.top > 0) || (insets.bottom > 0)
    }

seems to fix the problem, I'm working on a commit

Environment

  • iOS Version: iOS 11
  • Device(s): iPhone 8 Plus, iPhone 7, iPhone SE
@alexisakers
Copy link
Owner

This was fixed in commit 9ad27f5. Thank you for reporting!

@alexisakers alexisakers added this to Done in Release V2 Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release V2
  
Done
Development

No branches or pull requests

2 participants