Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe action doesn't work on ios10.2 #51

Closed
4 tasks done
mitolog opened this issue Jan 6, 2018 · 2 comments
Closed
4 tasks done

Swipe action doesn't work on ios10.2 #51

mitolog opened this issue Jan 6, 2018 · 2 comments
Labels
Projects

Comments

@mitolog
Copy link

mitolog commented Jan 6, 2018

New Issue Checklist

Issue Description

how to reproduce

  1. launch sample app(BB-Swift Scheme)
  2. press "Show Intro" button on the right navigation barbutton item
  3. try to swipe up/down
  4. then bulletinBoard and dimmed view doesn't respond anymore, only way to dismiss is just kill the app by pressing home button and open an app again.

quick workaround

just comment out of BulletinSwipeInteractionController.swif line 45 prepareGestureRecognizer(), though pan action cannot be usable.

Environment

  • iOS Version: [ios10.2]
  • Device(s): [iphone6s, not simulator]
@mitolog
Copy link
Author

mitolog commented Jan 6, 2018

As a quick(nasty...) workaround, you should set page.isDismissable = false additionally, otherwise it may crash on 2-3 times swiping action on the card.

@alexisakers alexisakers added this to To do in Release V2 Apr 29, 2018
@alexisakers alexisakers moved this from To do to In progress in Release V2 May 27, 2018
@alexisakers
Copy link
Owner

This issue seems to be fixed with version 2.0.0-beta.3, as changes have been made to the swipe gesture recognizer (users have to lift their finger to complete the dismissal). Please feel free to reopen this issue if you manage to reproduce it on this version or a later one.

Release V2 automation moved this from In progress to Done May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Release V2
  
Done
Development

No branches or pull requests

2 participants