Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace API #94

Closed
guybedford opened this issue Jun 9, 2016 · 3 comments
Closed

Trace API #94

guybedford opened this issue Jun 9, 2016 · 3 comments

Comments

@guybedford
Copy link
Collaborator

@capaj I know the trace API in SystemJS is somewhat inconsistent that results in the need to check both System.loads and System._loader.moduleRecords.

I'm currently looking at a new approach here, by leaving System.defined module entries available when System.trace is set to true, and this will be available in the coming SystemJS release.

If you're interested in taking a look at the structure, let me know if that can handle the hot-reloading cases going forward. As I would like to deprecate System.loads and System._loader.moduleRecords in the SystemJS major release coming in the next few months.

@born2net
Copy link

born2net commented Jun 9, 2016

thanks @guybedford for syncing with @capaj as we rely on hot-reloader heavily ...
regards

@alexisvincent
Copy link
Owner

SystemJS-HMR now uses System.defined

@alexisvincent
Copy link
Owner

I think we can close this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants