Skip to content
This repository has been archived by the owner on May 2, 2022. It is now read-only.

Possible Bug - Windows Server 2012 R2 x64, Node.js v0.10.22 #2

Closed
kevin-david opened this issue Nov 27, 2013 · 0 comments
Closed

Possible Bug - Windows Server 2012 R2 x64, Node.js v0.10.22 #2

kevin-david opened this issue Nov 27, 2013 · 0 comments
Labels

Comments

@kevin-david
Copy link

Working great, other than a small bug I encountered. When starting the proxy and connecting, I would get:

$ dispatch start
SOCKS5 server started on localhost:1080
Dispatching to addresses 192.168.42.226@1, 10.20.0.2@1, 192.168.1.155@1

C:\Users\Administrator\AppData\Roaming\npm\node_modules\dispatch-proxy\lib\utilities.js:18
  return value.join('.');
               ^
TypeError: Object 74 has no method 'join'
    at Object.exports.formatIPv4 (C:\Users\Administrator\AppData\Roaming\npm\node_modules\dispatch-proxy\lib\utilities.js:18:16)

For some reason, data.byte(4) on line 99 of socks.js was only returning the first octect of the destination IP address. I hack-fixed it by replacing commenting out line 99 and replacing it with the following:

//return u.formatIPv4(data.byte(4));
return data.byte(4) + '.' + data.byte(4) + '.' +  data.byte(4) + '.' + data.byte(4)

Thanks again for your contribution and open sourcing it - fast downloads are enjoyable. I was pulling >5MB/s earlier using cable and 4G internet :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant