Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Habitica stats info #6

Closed
ofekmiz opened this issue May 27, 2019 · 11 comments
Closed

Habitica stats info #6

ofekmiz opened this issue May 27, 2019 · 11 comments
Labels
enhancement New feature or request implemented Added feature

Comments

@ofekmiz
Copy link

ofekmiz commented May 27, 2019

I had an idea to add the Habitca's hp ,exp & gold to Trello's header:
image

I already implemented it on my user using cjs chrome plugin, If you like it I can send a pull request.
(I never did a pull request to another project before, some guidance would be appreciated 😊).

@alexktzk
Copy link
Owner

@ofekmiz I’ve seen your solution and even tried to add it to the project but problem is that it modifies DOM directly but not through the methods provided for Power-Ups.

We can use icons for board buttons so maybe a better solution would be to make 3 of them for every stats. Also they would look more Trello way.

@ofekmiz
Copy link
Author

ofekmiz commented May 29, 2019

Thanks for replying.
And thanks for this awesome power-up by the way.
Good to know that modifying the DOM is impossible for Trello Power-ups, Adding board buttons sounds like a good solution.

The main reason I think its a necessary feature is because checking tasks in trello doesn't give you that good feeling you get in Habitica when you check a task. In the Habitica site you can see the gold and exp you earned for the task instantly in a pop up message and cool sounds, that for some reason is really motivating.

Maybe instead of showing the stats we can just add popup message with the gold and exp earn for the task (there is a message like this in butler powerup for example).

@alexktzk
Copy link
Owner

@ofekmiz Thanks for your interest and ideas!

I wouldn’t say it’s not impossible but rather not preferred way. I just don’t think that Trello will accept this solution if we someday decide to submit this power-up to make it publicly accessible.

I agree with you, gamified part of Habitica is important and must be transfered to the power-up as well. I tried to add its basic implementation.

Screen Shot 2019-05-29 at 22 00 16

Screen Shot 2019-05-29 at 21 54 22

Screen Shot 2019-05-29 at 21 54 47

How it looks? Health points and mana points are not that important as exp and gold so I think this will be enough for now.

@alexktzk alexktzk added the enhancement New feature or request label May 29, 2019
@ofekmiz
Copy link
Author

ofekmiz commented May 29, 2019

Perfect!
How did you manage to add the max exp? I couldn't find it in the API

@alexktzk
Copy link
Owner

It just right there in stats, named "toNextLevel" :)

@ofekmiz
Copy link
Author

ofekmiz commented Jun 8, 2019

Is this live? :)
Should I reinstall the powerup? or it should update automatically when the feature is added?

@alexktzk
Copy link
Owner

alexktzk commented Jun 9, 2019

@ofekmiz It is live now :) No, just check your Trello board.

@alexktzk alexktzk added the implemented Added feature label Jun 9, 2019
@alexktzk alexktzk closed this as completed Jun 9, 2019
@ofekmiz
Copy link
Author

ofekmiz commented Jun 9, 2019

@alexktzk Thanks :) but it doesn't seem to work for me 😕 :
image
I tried to log out and log in, but it didn't help.

@alexktzk
Copy link
Owner

alexktzk commented Jun 9, 2019

@ofekmiz just move any card between done/doing lists to receive initial data

@ofekmiz
Copy link
Author

ofekmiz commented Jun 9, 2019

@alexktzk Yea, I just figured it out :) looks great!

@alexktzk
Copy link
Owner

alexktzk commented Jun 9, 2019

@ofekmiz yeah, nice suggestion you’ve made :) it looks more like Habitica now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implemented Added feature
Projects
None yet
Development

No branches or pull requests

2 participants