Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 v0.1.1 #42

Merged
merged 15 commits into from
Aug 22, 2019
Merged

📦 v0.1.1 #42

merged 15 commits into from
Aug 22, 2019

Conversation

actuallyReallyAlex
Copy link
Owner

No description provided.

@actuallyReallyAlex actuallyReallyAlex self-assigned this Aug 22, 2019
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

})}
</select>
<Box width="small">
<select onChange={handleChange}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

@actuallyReallyAlex actuallyReallyAlex merged commit daeb350 into master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant