Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✏️ Optimize - Delete PortfolioItem #428

Closed
1 task done
actuallyReallyAlex opened this issue Nov 5, 2020 · 0 comments
Closed
1 task done

✏️ Optimize - Delete PortfolioItem #428

actuallyReallyAlex opened this issue Nov 5, 2020 · 0 comments
Assignees
@actuallyReallyAlex
Labels
enhancement New feature or request
Projects
v5.3.0

Comments

@actuallyReallyAlex
Copy link
Owner

actuallyReallyAlex commented Nov 5, 2020 •
edited
Loading

Given that a user sends a request to delete a PortfolioItem, when the id parameter is used, then the server makes sure it isn't malicious.

Server

  • Scrub input on id
@actuallyReallyAlex actuallyReallyAlex added the enhancement New feature or request label Nov 5, 2020
@actuallyReallyAlex actuallyReallyAlex self-assigned this Nov 5, 2020
@actuallyReallyAlex actuallyReallyAlex added this to To do in v5.3.0 via automation Nov 5, 2020
actuallyReallyAlex pushed a commit that referenced this issue Nov 9, 2020
✏️ Optimize - Delete PortfolioItem #428 - Sanitize
70c396d
@actuallyReallyAlex actuallyReallyAlex mentioned this issue Nov 9, 2020
Merged
actuallyReallyAlex pushed a commit that referenced this issue Nov 9, 2020
Merge pull request #448 from alexlee-dev/rate-limit
131f0e5 
✏️ Optimize - Delete PortfolioItem #428 - Sanitize
v5.3.0 automation moved this from To do to Done Nov 9, 2020
@actuallyReallyAlex actuallyReallyAlex mentioned this issue Nov 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@actuallyReallyAlex actuallyReallyAlex

Labels
enhancement New feature or request
Projects
No open projects
v5.3.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@actuallyReallyAlex