Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ RateLimit - Don't Rate Limit on Local #461

Closed
1 task done
actuallyReallyAlex opened this issue Nov 10, 2020 · 0 comments
Closed
1 task done

✨ RateLimit - Don't Rate Limit on Local #461

actuallyReallyAlex opened this issue Nov 10, 2020 · 0 comments
Assignees
@actuallyReallyAlex
Labels
bug Something isn't working
Projects
v5.4.0

Comments

@actuallyReallyAlex
Copy link
Owner

actuallyReallyAlex commented Nov 10, 2020 •
edited
Loading

Given that a developer is working on the application, when the server uses middleware in development mode, then it does not use the rate limiter middleware.

Server

  • Adjust app.use() line
@actuallyReallyAlex actuallyReallyAlex added the bug Something isn't working label Nov 10, 2020
@actuallyReallyAlex actuallyReallyAlex self-assigned this Nov 10, 2020
@actuallyReallyAlex actuallyReallyAlex added this to To do in v5.4.0 via automation Nov 10, 2020
@actuallyReallyAlex actuallyReallyAlex moved this from To do to In progress in v5.4.0 Nov 10, 2020
actuallyReallyAlex pushed a commit that referenced this issue Nov 10, 2020
✨ RateLimit - Don't Rate Limit on Local #461 - Adjust server
b5490f9
@actuallyReallyAlex actuallyReallyAlex mentioned this issue Nov 10, 2020
Merged
actuallyReallyAlex pushed a commit that referenced this issue Nov 10, 2020
Merge pull request #462 from alexlee-dev/rate-limit
f20180d 
✨ RateLimit - Don't Rate Limit on Local #461 - Adjust server
v5.4.0 automation moved this from In progress to Done Nov 10, 2020
@actuallyReallyAlex actuallyReallyAlex mentioned this issue Nov 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@actuallyReallyAlex actuallyReallyAlex

Labels
bug Something isn't working
Projects
No open projects
v5.4.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@actuallyReallyAlex