Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCNN layers missing labels #14

Closed
eshrh opened this issue Dec 17, 2018 · 4 comments
Closed

FCNN layers missing labels #14

eshrh opened this issue Dec 17, 2018 · 4 comments

Comments

@eshrh
Copy link

eshrh commented Dec 17, 2018

Hey!
I really liked using this tool as a very simple visualization for models, but there might be a bug in the FCNN style.

Adding a extra node at the end of the model leads to a missing Output Layer label. Similarly, adding an extra node after that one leads to both nodes missing their labels.
Here's what I mean

I would have loved to try to PR and solve it myself, but I'm not too comfortable with JS, so I think I'm out of my league a little here!

@eshrh eshrh changed the title Bug in FCNN figure output layer label FCNN layers missing labels Dec 17, 2018
@alexlenail
Copy link
Owner

Thanks for the bug report, @eshanrh ! I added the labels at the very end so they're liable to have a few bugs. I'll look into it!

@eshrh
Copy link
Author

eshrh commented Dec 17, 2018

That's totally fine, I ended up hiding labels and then adding them myself which wasn't hard at all, but I thought it might be nice to have it working for everyone else!

@alexlenail
Copy link
Owner

@eshanrh would you check for me that this is fixed now (check http://alexlenail.me/NN-SVG/ and make sure to refresh the cache / visit it in incognito)?

If it isn't fixed, I'd much appreciate some repro steps =)

@eshrh
Copy link
Author

eshrh commented Jan 2, 2019

Works perfectly!

@eshrh eshrh closed this as completed Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants