Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height issue #19

Closed
lubomirblazekcz opened this issue Aug 9, 2021 · 6 comments
Closed

Height issue #19

lubomirblazekcz opened this issue Aug 9, 2021 · 6 comments

Comments

@lubomirblazekcz
Copy link
Contributor

Proposed Feature or Bug

When the content inside wrapper is updated and height is changed, the height is not updated. I think it would be better to add height: auto, once the wrapper is fully open. And upon closing update the height again?

@cnaa97
Copy link

cnaa97 commented Aug 23, 2021

+1

@alexmacarthur
Copy link
Owner

@lubomirblazekcz, @cnaa97 Could you explain your use cases for this a little more? In my own cases, I've preferred to leave the any explicit style values out of the markup for cleanliness. But there may be a scenario I'm not thinking of.

@cnaa97
Copy link

cnaa97 commented Sep 9, 2021

@alexmacarthur In my case, when each children (li element) has different height size or fluid (like iframe youtube video, image load dynamically) this problem has occurred

@cnaa97
Copy link

cnaa97 commented Sep 9, 2021

Screen Shot 2021-09-09 at 6 20 09 PM

@lubomirblazekcz
Copy link
Contributor Author

For me is the issue with any dynamic content iside the wrapper. And that could be anything, adding removing items, textarea or something with fluid height as @cnaa97 mentioned.

@alexmacarthur
Copy link
Owner

Sorry for the delay on this, @lubomirblazekcz + @cnaa97! Fixed in the latest release:

https://github.com/alexmacarthur/slide-element/releases/tag/v2.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants