Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure callback fires only after animation is finished. #30

Merged
merged 3 commits into from Jan 24, 2022

Conversation

alexmacarthur
Copy link
Owner

Description of Proposed Changes

Due to poor Promise handling, the callback function passed to slide-element was firing without waiting for animations to fully complete.

@github-actions
Copy link

Size Change: +50 B (+3%)

Total Size: 1.9 kB

Filename Size Change
dist/index.es.js 1.04 kB +32 B (+3%)
dist/index.umd.js 868 B +18 B (+2%)

compressed-size-action

@alexmacarthur alexmacarthur merged commit 335fd00 into master Jan 24, 2022
@alexmacarthur alexmacarthur deleted the fix-callback branch January 24, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant