Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Options module #2

Closed
sbennett33 opened this issue Aug 6, 2019 · 1 comment
Closed

Typo in Options module #2

sbennett33 opened this issue Aug 6, 2019 · 1 comment

Comments

@sbennett33
Copy link

There is a typo in the Options module which prevents this library from working properly.

https://github.com/sascha-wolf/knigge/blob/1fb2f223b3818a1a674878ae4552a7e413d3bbf9/lib/knigge/options.ex#L83

You are trying to read opt_app from the options list instead of otp_app.

@sascha-wolf
Copy link
Collaborator

sascha-wolf commented Aug 7, 2019

Damn, as it turned out the covering test didn’t run because I named it incorrectly. That's my punishment for not doing strictly TDD. 😄

It's fixed in 1.0.2 (2bd845b), thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants