Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings to match the actual exported api format #42

Closed
soft-decay opened this issue Nov 30, 2020 · 3 comments
Closed

Fix typings to match the actual exported api format #42

soft-decay opened this issue Nov 30, 2020 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@soft-decay
Copy link
Contributor

soft-decay commented Nov 30, 2020

@alexprey As you said, the typings should be updated to match the actual api.

First thing I found is :

export interface SvelteDataItem extends ISvelteItem {
// ...
/**
 * The default value of property, if provided.
 */
value?: any;
// ...
}

but the exported key is actually defaultValue (see the example Button).

Which one should be kept?

@alexprey alexprey added this to the 4.0.0 milestone Nov 30, 2020
@alexprey alexprey added the bug Something isn't working label Nov 30, 2020
@alexprey
Copy link
Owner

Thanks for that catch, I'm fix it. And also update the API for default value of optional parameter

@soft-decay
Copy link
Contributor Author

soft-decay commented Nov 30, 2020

I just saw you pushed modifications for the typings, but I made a mistake when I renamed SvelteMethodArgumentItem to SvelteMethodParamItem.

It should be:

/**
 * @deprecated
 */
export type SvelteMethodArgumentItem = SvelteMethodParamItem;

and you can delete type SvelteArgItem and type SvelteArgumentItem, I added them by mistake in #40, so they were never released.

@alexprey
Copy link
Owner

alexprey commented Dec 1, 2020

Ok, thanks for note about that, I'm remove this types from typings file.

@alexprey alexprey self-assigned this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants