Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command line scaling broken in master #1889

Closed
beanz opened this issue Apr 1, 2014 · 2 comments
Closed

Command line scaling broken in master #1889

beanz opened this issue Apr 1, 2014 · 2 comments
Labels
Fixed
Milestone
1.1.1

Comments

@beanz
Copy link
Collaborator

beanz commented Apr 1, 2014

Between 2eff7c2 and 916a0a0 scaling is broken on the command line. For instance, --scale 2.0 any stl (I tried a Teethy Tiki and a simple 20x20x5 box) and the resulting gcode is truncated at a little above the original max Z.
@beanz
Copy link
Collaborator Author

beanz commented Apr 1, 2014

Looks like it was broken by 0591eec.

@alranel alranel added this to the 1.1.1 milestone Apr 4, 2014
alranel added a commit that referenced this issue Apr 5, 2014
@alranel
Failing test for broken command line scaling. #1889
e9e2311
alranel added a commit that referenced this issue Apr 5, 2014
@alranel
Fixed broken command line scaling. Regression test was in previous co…
20df102 
…mmit. #1889
@alranel
Copy link
Member

alranel commented Apr 6, 2014

Fixed in 20df102, thank you!

@alranel alranel closed this as completed Apr 6, 2014
@alranel alranel added the Fixed label Apr 6, 2014
@alranel alranel mentioned this issue Apr 18, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
2 participants
@beanz @alranel