Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M109 is deprecated #746

Closed
Traumflug opened this issue Oct 11, 2012 · 6 comments
Closed

M109 is deprecated #746

Traumflug opened this issue Oct 11, 2012 · 6 comments

Comments

@Traumflug
Copy link

Looking at this post: http://forums.reprap.org/read.php?146,159676,159890#msg-159890
slic3r uses M104 first, then M109 for waiting, giving an extruder temperature command twice. M109 is deprecated and M116 is (and always was) the "wait for temperatures" command. Should be an easy fix.

@sysdump
Copy link

sysdump commented Oct 11, 2012

It's deprecated in Marlin but not in Sprinter. M116 is not implemented in the master branch of Sprinter.

@alranel
Copy link
Member

alranel commented Oct 11, 2012

Is M109 deprecated in Marlin? Where's that written?
Is M116 supported by Marlin? I can't find it in its source code.

@Traumflug
Copy link
Author

Thanks for visiting this. It's written in the RepRap wiki:
http://reprap.org/wiki/G-code#M116:_Wait and
http://reprap.org/wiki/G-code#M109:_Set_Extruder_Temperature_and_Wait

Teacup follows the wiki, don't know about Marlin. Before you think I've deprecated it myself, it was Adrian Bowyer to do so: http://reprap.org/mediawiki/index.php?title=G-code&diff=next&oldid=61537

@alranel
Copy link
Member

alranel commented Oct 11, 2012

Slic3r supports multiple G-code flavors. I'll make sure that it uses M116 for Teacup, but I'll make sure that it uses commands that Sprinter and Marlin support when their flavor is selected.

@Traumflug
Copy link
Author

Sounds good!

@alranel
Copy link
Member

alranel commented Oct 15, 2012

I checked, and Slic3r already emits M116 instead of M109 when the Teacup G-code flavor is selected. So, no need to do any change with regards to this issue.

@alranel alranel closed this as completed Oct 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants