Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove main opt #3671

Closed
wants to merge 3 commits into from
Closed

Conversation

lordofhyphens
Copy link
Member

Been seeing an undefined "entry" error

Use of uninitialized value in subroutine entry at /mnt/fiver/slic3r/lib/Slic3r/GUI/Plater.pm line 1228.

Tracked it to the use of $main::opt{output}. Removed it and didn't see any changed behavior.

@lordofhyphens
Copy link
Member Author

I think main::opt is actually supposed to reference "remember output directory" setting.

@alranel
Copy link
Member

alranel commented Feb 28, 2017

$main::opt{output} holds the contents of the CLI --output argument, which is used as default value for the export dialog. It's a pretty hidden feature, but I think it's there for a good reason.

Better to add // '' after it in order to turn the undef value to an empty string and suppress the warning.

@lordofhyphens
Copy link
Member Author

Looks like this was fixed by @alexrj. Closing.

@lordofhyphens lordofhyphens deleted the remove_main_opt branch March 11, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants