Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure messages view is scrolled to bottom when new messages are added #18

Closed
martinverhey opened this issue Apr 17, 2023 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@martinverhey
Copy link

martinverhey commented Apr 17, 2023

When you're at the bottom of the chat, it should focus on showing the generated text, as it's being generated. Which means, it should automatically scroll to a new line as it's being generated.

Now the newly generated messages go off-screen at the bottom and you have to manually scroll continuously to read each line as it's being generated.

Same goes for showing your own message at the bottom when pressing enter.

@alexrozanski
Copy link
Owner

Hey @martinverhey, thanks for filing! I tried to get this to work (there is a temporary implementation here: https://github.com/alexrozanski/LlamaChat/blob/main/LlamaChat/ui/chat/messages/MessagesView.swift#L61) but the messages view needs reimplementing as there's no built-in way to do this in SwiftUI.

Will get to this soon ✌️

@alexrozanski alexrozanski self-assigned this Apr 17, 2023
@alexrozanski alexrozanski added the enhancement New feature or request label Apr 17, 2023
@alexrozanski alexrozanski added this to the v1.2 milestone Apr 17, 2023
@alexrozanski alexrozanski changed the title Show generated message in view at the bottom while generating Ensure messages view is scrolled to bottom when new messages are added Apr 18, 2023
@alexrozanski
Copy link
Owner

Fixed in v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants