Renaming UserDefault property wrapper #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `UserDefault` naming scheme conflicts with other popular Swift Packagaes such as Guillermo Muntaner's "Burritos" package (which also happens to define a UserDefault property wrapper). By prepending "Secure" the behavior is more explicit.
|
🙌 Thanks for your contribution! 🎉🥳 You're awesome. |
|
Code Climate has analyzed commit 9eedeff and detected 0 issues on this pull request. View more on Code Climate. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
:( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
What changes did you make? (Give an overview)
Renamed
@UserDefault(and related) property wrappers to@SecureUserDefaultbecause the type name as well as the target name conflicts with other Swift Packages (i.e. Guillermo Muntaner's Burritos) that also provideUserDefault-related property wrappers (although with different functionality).Which issue (if any) does this pull request address?
This does not address a specific existing issue, however it does resolve SPM import conflicts on Xcode 11+.
Is there anything you'd like reviewers to focus on?
I realize that this PR may be invalid, or moving in an undesirable direction for the project. However, I thought it was worthwhile to share not only as a fix for the aforementioned issue, but because a more verbose name makes it clearer what the function of this property wrapper is. In fact, I believe that the readability of code using this library would be greatly improved if all of the included property wrappers were prepended with
Secure. Of course, that might just be a picky programmer preference I have -- to each their own!Regardless, I love the package and am very thankful for your hard work and contribution to the community. I'll be using it in more than a few App Store projects :) 🥂
This change is